JuliaEditorSupport/JuliaFormatter.jl

julia> s = "x;;;; y" "x;;;; y" julia> ft(s) "x;;;;\ny" There's an argument here that we should get rid of three of those semicolons.

Would it be possible to add an option that controls the whitespace surrounding (nested) brackets? I'm one of the few people that think the following f( g( h( a[ 1 ] ), b ) ) is more readable than f(g(h(a[1]), b)) The above example is a bit extreme but even just h( a[ 1 ], b ) looks nicer to me than h(a[1], b) I assume whitespace lovers don't really agree on whether f( g( x ) ) is better than f( g(x) ) (i.e. extra whitespace after every opening and before every closing bracket vs only for nested brackets) so I would propose to have two options extra whitespace only for nested expressions. The inner most brackets of any subexpression have regular spacing. f(g(h(a[1], b), k(x))) would become f( g( h( a[1], b ), k(x) ) ) extra whitespace after every opening and before every closing bracket f(g(h(a[1], b), k(x))) would become f( g( h( a[ 1 ], b ), k( x ) ) ) I'm sorry if this is too much of a niche request and I hope I don't start a flamewar here (a bit hard to avoid though when posting

the intent of the pre-commit config is presumably to make sure that JuliaFormatter is formatted with the current version of itself. JuliaFormatter.jl/.pre-commit-config.yaml Line 8 in 09da91d entry: "jlfmt --inplace" however invoking jlfmt does not necessarily achieve that as jlfmt could be literally any version of JuliaFormatter. it will only give the right behaviour if the person running it has done ]app dev . before that.

Consider: s = """ (; a= >=(1)) (; a=2) (; a=+2) (; a=+x) (; a=+x/2) (; a=+(2)) """ using JuliaFormatter: format_text as ft ft(s; whitespace_in_kwargs=false) |> println Looking at #360 and #361 the real underlying reason behind that PR was to make sure that the first of the above did not get converted into (; a=>=1), which would fail to parse as => is an operator. However, looking at the actual code in #361 it's very clear that the intent was to parenthesise anything on the RHS that began with an operator. This is overly cautious, because =+ is not a valid operator and thus things like (; a=+x) parse totally fine. Now, recent versions of JuliaFormatter have led to changes in the underlying operator-detection mechanism. This is the outcome with several different versions of JuliaFormatter: v1.0.62 v2.5.2 # 1011 (; a=(>=(1))) (; a=(>=(1))) (; a=(>=(1))) (; a=2) (; a=2) (; a=2) (; a=+2) (; a=+2) (; a=+2) (; a=+x) (; a=(+x)