swiftlang/sourcekit-lsp

Currently, many of the code actions in SwiftLanguageService/CodeActions directly conform to SyntaxCodeActionProvider. For those for which it makes sense, I think we could avoid some boilerplate (and add some more structure) by making the code action conform to SyntaxRefactoringCodeActionProvider as well as SyntaxRefactoringCodeActionProvider, removing the explicit implementation of codeActions(in:) and instead rely on the synthesized version. As this is a learning-oriented task, please don’t address this purely by using an AI tool, as described in https://github.com/swiftlang/project-operations/blob/main/contributing/ai-tools.md#learning-oriented-contributions.

Description Toggle a test between enabled and disabled states. Swift Testing: Before: @Test func testExample() { #expect(2 + 2 == 4) } After: @Test(.disabled()) func testExample() { #expect(2 + 2 == 4) } XCTest: Before: func testExample() { XCTAssertEqual(2 + 2, 4) } After: func testExample() throws { throw XCTSkip("Disabled") XCTAssertEqual(2 + 2, 4) }

Description Generate computed properties to extract associated values from enum cases. Before: enum Value { case text(String) case number(Int) } After: enum Value { case text(String) case number(Int) var asText: String? { if case let .text(v) = self { return v } return nil } var isText: Bool { if case .text = self { return true } return false } var asNumber: Int? { if case let .number(v) = self { return v } return nil } var isNumber: Bool { if case .number = self { return true } return false } } See also: rust-analyzer generate_enum_as_method

Description Replace a temporary variable with its value at all usage sites. Example Before: func example() { let basePrice = item.price let total = basePrice * quantity } After: func example() { let total = item.price * quantity }

Swift version 6.2.3 Platform Arch Linux Editor Visual Studio Code Swift plugin 2.14.2 and also my own JetBrains plugin (Noctule) Description Refactoring "Convert string literal to minimal number of "#"s" does not handle string literals correctly, which would have to have escaped characters after the conversion. Steps to Reproduce Place the text cursor into the string literal and then invoke the refactoring "Convert string literal to minimal number of "#"s" let x = #"""# The file is then turned into this, which is incorrect because the previously literal double quote `"' is now unescaped: let x = """ I think either the refactoring should not be offered or the result should be properly escaped. Logging No response