stjude-rust-labs/sprocket

Is your feature request related to a problem? Please describe. MetaSections currently only checks structs in documents v1.2 or higher (when meta/parameter_meta support was added). However, since #1185, MetaSections is also doc-comment-aware. Describe the solution you'd like MetaSections currently always suggests a meta/parameter_meta section. For documents v1.1 and older, we should lint structs but suggest doc comments instead. For v1.2 and above we should produce the current meta/parameter_meta suggestion. Additional context #1185 (comment)

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. I just ran the below one-liners: sprocket dev server status --json --status completed | jq '.runs.[].name' -r > completed_names.txt while IFS= read -r name; do sprocket dev server inspect $name --json; done < completed_names.txt | jq -rs '.[].directory' | tee dirs.txt the first command finished very fast, no complaints there. But the loop took 90 seconds to run for a completed_names.txt file with 713 runs. That is pretty darn fast in the grand scheme of things, but I imagine it would have been even faster if I was able to do it in a single command instead of >700 sprocket invocations. Describe the solution you'd like A clear and concise description of what you want to happen. Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered. Additional context Add any other context or screenshots about th

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. As pointed out by Andrew in review of #1034 - #1034 (comment) Should this get abstracted into a helper? It's reimplemented in multiple places. This is specifically in response to a repeated pattern for handling comma delimited format elements, but there are a number of similar patterns throughout the wdl_format::v1 module. It's natural for formatting code to end up repetitive, as we want similar elements to be formatted similarly. However this causes a maintenance burden as similar logic ends up scattered throughout the module and changes in one place may not get reflected elsewhere. Describe the solution you'd like A clear and concise description of what you want to happen. I responded: I considered making a macro for it, a helper function would be suitable as well. FWIW, there are a lot of repetitive patterns in the v1 module due to the nature of formatting. It's

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. While writing tests for a WDL workspace, dev test has a few ways to drill down which tests to run (or not run) but none of them allow for much specificity. The current relevant options are: Usage: sprocket dev test [OPTIONS] [SOURCE] Arguments: [SOURCE] Local path to a WDL document or workspace to unit test Options: -w, --workspace <WORKSPACE> Root of the workspace where the `test/` directory will be located. Test fixtures will be loaded from `<workspace>/test/fixtures/` if it is present -t, --include-tag <TAG> Specific test tag that should be run -f, --filter-tag <TAG> Filter out any tests with a matching tag [SOURCE] can be the path to a single WDL document, but it will try and run every test found for that document (not filtered by -t and -f). Describe the solution you'd like A clear and concise description of what you want to hap

Summary Add a new lint rule PreferStructOverMap that flags Map[String, *] types in declarations where a Struct would provide clearer semantics and better validation. This encourages use of WDL's type system for self-documenting interfaces. Details Tags: Clarity Applies to: all declarations (inputs, outputs, private) in tasks and workflows. WDL >= 1.1 only. Default: no-op (pedantic-only rule) Pedantic: emits warning Good example struct SampleInfo { String sample_id String library File fastq_r1 File fastq_r2 } task align { input { SampleInfo sample File reference } # ... } Bad example task align { input { # lint: PreferStructOverMap — consider using a Struct instead of Map[String, String] Map[String, String] sample_info # lint: PreferStructOverMap — consider using a Struct instead of Map[String, File] Map[String, File] input_files File reference } # ... } Edge cases Legitimate uses of