rust-lang/rust-clippy

Summary You were the Chosen One! It was said that you would destroy the Sith, not join them! Clippy tries to break perfectly working code then fails. Reproducer Code: [dependencies] async-recursion = "=1.1.1" #[async_recursion::async_recursion] pub async fn f() { f().await } Current output: error: errors present after applying fixes to crate `clippy_repro_async_recursion` --> src/lib.rs = cause: error[E0733]: recursion in an async fn requires boxing --> src/lib.rs:1:1 | 1 | pub async fn f() { | ^^^^^^^^^^^^^^^^ 2 | f().await | --------- recursive call here | = note: a recursive `async fn` call must introduce indirection such as `Box::pin` to avoid an infinitely sized future error: aborting due to 1 previous error For more information about this error, try `rustc --explain E0733`. help: to report this as a bug, open an issue at https://github.com/ru

Summary For this issue: warning: use of irregular braces for `format!` macro --> crates/resolver/src/hosts.rs:246:9 | 246 | format! {"{server_path}/crates/resolver/tests"} | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider writing: `format!("{server_path}/crates/resolver/tests");` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.99.0/index.html#nonstandard_macro_braces = note: `#[warn(clippy::nonstandard_macro_braces)]` on by default --fix produced this diff: diff --git a/crates/resolver/src/hosts.rs b/crates/resolver/src/hosts.rs index b314f4665..92ce94c0d 100644 --- a/crates/resolver/src/hosts.rs +++ b/crates/resolver/src/hosts.rs @@ -243,7 +243,7 @@ mod tests { fn tests_dir() -> String { let server_path = env::var("TDNS_WORKSPACE_ROOT").unwrap_or_else(|_| "../..".to_owned()); - format! {"{server_path}/crates/resolver/tests"} + format!("{server_path}/crates/resolve

Summary The unnecessary_fold lint suggests using any over, e.g., fold(false, |acc, x| acc || x) because the former short-circuits. But whether or not short-circuiting is wanted depends, for example, iterators or fold closures may have side-effects. The previous example is therefore ambiguous because it uses the short-circuiting || op. It ought explicitly either short-circuit via any or use the non-short-circuiting | op. Alternative solution to the #3351 issue Reproducer Code: /// Broadcasts all previously recorded events to their respective listeners. /// /// Returns `true` if an event was delivered to at least one listener. fn broadcast(&self) -> bool { self.storage .iter() // Any signal of this kind arrived since we checked last? .filter(|event_info| event_info.pending.swap(false, Ordering::SeqCst)) // Ignore errors if there are no listeners .map(|event_info| event_info.tx.send(()).is_ok()) .fold(false, |acc, x| acc || x) } Current

Summary module_name_repetitions no longer lints when the name that is repetitive is in a re-export group. Lint Name module_name_repetitions Reproducer I tried this code: #![warn(clippy::module_name_repetitions)] pub mod space { mod happening { pub struct SpaceTime {} pub struct SpaceWedgie {} pub struct NegativeSpaceWedgie {} } pub use happening::SpaceTime; pub use happening::{NegativeSpaceWedgie, SpaceWedgie}; } I expected to see this happen: Lint on SpaceTime and SpaceWedgie re-exports, as on stable 1.98.1: warning: item name starts with its containing module's name --> src/lib.rs:10:24 | 10 | pub use happening::SpaceTime; | ^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#module_name_repetitions note: the lint level is defined here --> src/lib.rs:1:9 | 1 | #![warn(clippy::module_name_repetitions)] | ^^^^^^^^^^^^^^^^^^

Summary clippy::useless_attribute flags clippy::allow_attributes on use. However, clippy::allow_attributes is needed on a use to suppress that lint for allow(unused_imports) (or potentially other valid allow attributes). Those allows themselves are, in turn, needed when inside a macro where the lint might only fire on some applications (due to #17562 ). Lint Name useless_attribute Reproducer #[expect(clippy::allow_attributes, reason = "lint depends on macro application")] #[allow(unused_imports)] use path::to::something::unused; Version rustc 1.97.1 (8bab26f4f 2026-07-14) binary: rustc commit-hash: 8bab26f4f68e0e26f0bb7960be334d5b520ea452 commit-date: 2026-07-14 host: x86_64-unknown-linux-gnu release: 1.97.1 LLVM version: 22.1.6 Additional Labels No response