rocky-data/rocky

What policy.rs has three more text renderers that still call println!, so no test can read what they produce: Function Command render_test_text rocky policy test render_text rocky policy check render_freeze_text rocky policy freeze / unfreeze Give each the shape #1879 gave render_show_text: fn render_test_text<W: Write>(w: &mut W, out: &PolicyTestOutput) -> io::Result<()> Why this is a separate issue and not part of #1879 Changing the signature is the cheap half and it delivers nothing on its own. The value is the tests, and the assertion has to be the whole block — a substring assertion is the exact weakness #1879 exists to close, because round one of the #1874 review lost a line that was present and merely shorter. So this is four renderers' worth of full-block tests, each needing its own output fixture. That is its own review, not a rider on a PR that closed one renderer. Why it matters here render_freeze_text is the highest-value of the three. It prints the ! {note}

Five RockyClient methods carry a worked Example: block. The six product_* methods carry none. They explain what the command does, but never show a caller what to do with the object that comes back. rocky product is the spec-driven data-product surface, and its result objects are the least obvious in the SDK — product_verify in particular returns a report whose status must be read instead of the exit code. That is exactly the thing an example should show. What is there now sdk/python/src/rocky_sdk/client.py: Method Line Has Example: discover 896 yes plan 941 yes apply 987 yes review_status 1037 yes run 1172 yes product_verify 1080 no product_compile 1102 no product_approve 1116 no product_status 1130 no product_list 1143 no product_journal 1157 no The slice Add an Example: block to each of the six, following the format discover uses (client.py:896): reStructuredText, a sentence of framing, then a :: literal block. Example: List every

rocky lineage-diff is the one Modeling command with no reference section. It appears twice in the CLI reference — once in the group list, once as an un-linked row in the command index — and nowhere else. A reader who wants its flags has to run --help. Every other Modeling verb (compile, lineage, test, ci, ci-diff, preview, emit-sql, catalog, publish-ir, imports) has a full section in docs/src/content/docs/reference/commands/modeling.md. What is there now docs/src/content/docs/reference/cli.md:11 group list: "..., `lineage`, `lineage-diff`, `test`, ..." docs/src/content/docs/reference/cli.md:38 | `lineage-diff` | Report the downstream blast radius of a change, for PR review. | That index row is un-linked, because there is no section to link to. Nothing under reference/commands/ documents the command. The slice Add a ## \rocky lineage-diff`section todocs/src/content/docs/reference/commands/modeling.md, then link the index row in cli.md:38` to it. Copy the shape of the ## \rocky

The Rocky language server completes model names, column names, and SQL functions. It never offers a pipeline step keyword. Typing de in a .rocky file suggests SQL functions, not derive. Every other piece is already in place: the keyword list exists as a constant, and the completion handler already knows which file it is completing in. What is there now engine/crates/rocky-server/src/lsp.rs:1370 — async fn completion(...). It dispatches on get_completion_context: CompletionContext::ModelReference -> model names (lsp.rs:1388) CompletionContext::ColumnReference -> columns of that model (lsp.rs:1409) CompletionContext::Function -> SQL_FUNCTIONS (lsp.rs:1425) CompletionContext::Unknown -> SQL_FUNCTIONS + models (lsp.rs:1434) No arm contributes a keyword. The list already exists, one screen away, used by the document-symbol path: // lsp.rs:4069 /// Pipeline step keywords recognized in `.rocky` files. const ROCKY_STEP_KEYWORDS: &[&str] = &[

The VS Code TextMate grammar highlights 10 of the DSL's keywords. Seven more are real syntax the parser consumes, and they render as plain identifiers today. Window frames are the visible gap: an entire over (partition by ... rows between unbounded preceding and current row) clause has no colour at all. This is a single-file change in editors/vscode/. No engine code, no just codegen. What is there now editors/vscode/syntaxes/rocky.tmLanguage.json, the pipeline-steps repository entry: { "match": "\\b(from|where|group|derive|select|join|sort|take|distinct|replicate)\\b", "name": "keyword.control.rocky" }, { "match": "\\b(as|on|keep|asc|desc|inner|left|right|cross|full)\\b", "name": "keyword.other.rocky" } The gap Every keyword below is a #[token(...)] in engine/crates/rocky-lang/src/token.rs and is consumed by the parser. None is highlighted: Keyword token.rs Consumed at let :13 parser.rs:145, :178, :195 — a model-level declaration over :73 parser.rs:933 partition :75 pa