rational-kunal/NeoBrutalism

.github/workflows/ci.yml filters on: paths: - "Sources/**" - "Tests/**" - "Example/**" - ".github/workflows/**" - "Package.swift" Scripts/ isn't listed, but it holds the snapshot contract: Scripts/snapshot-env.sh pins the reference simulator (iPhone 16 / iOS 26.2) and the CI Xcode, and carries the comment "Change ONLY via a PR that also re-records every image". Scripts/test.sh controls how the suite is invoked, including the deliberate -parallel-testing-enabled NO. A PR touching only Scripts/ skips CI entirely, so nothing enforces that rule at exactly the moment it matters most. Suggested fix Add - "Scripts/**" to both the push and pull_request path filters. Found while reviewing #47 (v3.0.0). Not blocking the release.

Sources/NeoBrutalism/Components/Dialog.swift:17-21: /// Tapping the scrim dismisses the dialog; actions must call /// your binding manually (just like SwiftUI's `alert` does). To apply destructive /// styling to a button, pass `.buttonStyle(.neoBrutalism(type: .neutral))` with a /// red-tinted theme, or document the limitation for your consumers. "…or document the limitation for your consumers" is an instruction to whoever was writing the library, not guidance for someone using it. It ships to the hosted DocC page for nbDialog. Worth rewriting that sentence to just state the limitation: Button(role: .destructive) inside nbDialog doesn't get destructive styling, and here's what to do about it. Found while reviewing #47 (v3.0.0). Not blocking the release.

Sources/NeoBrutalism/Components/Menu/NBMenu.swift:193: let screenHeight = UIScreen.main.bounds.height let scrollCap = screenHeight * 0.6 UIScreen.main is not scene-aware — it reports the device screen, not the window the menu is actually in — so the 60% cap is wrong under iPad Split View / Slide Over, in a resized window, or on an external display. It's also deprecated. The value is already available: NBMenuOverlayContent.body wraps everything in a GeometryReader whose proxy.size is passed to placement(in:) a few lines above. Suggested fix Thread that same size into dropdown(elevated:) instead of reaching for UIScreen.main. Found while reviewing #47 (v3.0.0). Not blocking the release.

NBGaugeStyle.makeBody reads only configuration.value and configuration.label: public func makeBody(configuration: Configuration) -> some View { let value = configuration.value HStack(spacing: theme.spacing) { configuration.label NBBarMeter(fraction: value) … } } — Sources/NeoBrutalism/Components/Gauge/GaugeStyle.swift So a Gauge built with any of the value labels silently loses them: Gauge(value: temp, in: 0...100) { Text("Temp") } currentValueLabel: { Text("\(temp)°") // never rendered } minimumValueLabel: { Text("0") // never rendered } maximumValueLabel: { Text("100") // never rendered } Related: #3 asks for the same thing on NBProgressViewStyle, so the two could share a layout decision. NBGaugeStyle's static var neoBrutalism is also the only style entry point in the library without a doc comment — worth adding in the same pass. Found while reviewing #47 (v3.0.0). Not blocking the rele

NBSegmentBuilder only implements the variadic buildBlock: @resultBuilder public struct NBSegmentBuilder<Value: Hashable> { public static func buildBlock(_ components: NBSegmentItem<Value>...) -> [NBSegmentItem<Value>] { components } } — Sources/NeoBrutalism/Components/SegmentedPicker/NBSegmentedPicker.swift So neither of these compiles inside an NBSegmentedPicker: NBSegmentedPicker(selection: $size) { ForEach(sizes) { Text($0.name).nbSegment($0) } // ✗ if showExtras { Text("XL").nbSegment(3) } // ✗ } NBMenuBuilder and NBTabBuilder in the same release both implement buildExpression / buildArray / buildOptional / buildEither, so this is an inconsistency between three builders that otherwise look alike. Suggested fix Mirror NBTabBuilder — it's the closest analogue and can be copied nearly verbatim. Found while reviewing #47 (v3.0.0). Not blocking the release.