pulseaiclub/phi

internal/tools/bashtool/bash.go (101 lines) is 0.0% covered while the package sits at 70.2%: BashTool(), bashDetail, and runBash have never been executed. The existing tests only exercise helpers (ExecShell, formatBashOutput, newCappedBuffer, shell discovery), so the entry point the agent hits most often — plus its timeout clamping and error suffixes — is unpinned. It is a self-contained handler: typed bashInput in, tooldef.Result out, IO only through the already-tested buildShellCommand path. Add internal/tools/bashtool/bash_test.go covering: • runBash — empty and whitespace-only command → error empty command • success — printf hi → Content "hi", Detail "printf hi" • non-zero exit — exit 3 → "(no output)\n(exit error: exit status 3)" • empty output — true → "(no output)" • stderr — printf err >&2 → Content "err" • timeout — {"command":"sleep 2","timeout":1} → "(no output)\n(command canceled or timed out)", and the call returns in ~1s (assert ela

internal/tools/greptool/grep.go (529 lines) sits at 70.1% but the output-size guards are barely touched: truncateHead 9.5%, exitCode 0.0%, truncateLine 66.7%, formatBytes 66.7%. These decide what the model actually receives when a search matches a lot — the difference between a usable result and a tool message that blows the context. Pure string/int functions, no IO. Add internal/tools/greptool/truncate_test.go covering: • truncateHead — content shorter than max passes through with Truncated == false; content exactly max is not truncated; first line longer than max → {Content: "", Truncated: true}; a multi-line body truncates on a line boundary and never exceeds max (count the newline byte); single line • truncateLine — maxChars <= 0 falls back to grepMaxLineRunes; short line returns (line, false); long line returns prefix + grepTruncatedSuffix with true; CJK counted by rune, not byte • formatBytes — 0 → "0B", 1023 → "1023B", 1024 → "1KB", non-multiples floor •

internal/tools/mcptool/mcp.go sits at 30.8%: listTool 33.3%, inspectTool 14.3%, callTool 14.3%. These three are the only MCP surface the model ever sees, and their rule is that schemas never enter the model context and errors go back verbatim. The success path needs a fake stdio MCP server (not for a first issue) but the schema and failure paths need no server at all: *mcp.Pool with a config map whose server name does not match fails before any connection. Add cases to internal/tools/mcptool/mcp_test.go covering: • schemas — mcp_inspect and mcp_call require exactly [server, tool], mcp_list requires [server]; all three Params.Type == "object" • DetailFromArgs — mcp_inspect/mcp_call render server/tool, mcp_list renders the server • error pass-through — pool := mcp.NewPool(map[string]mcp.ServerConfig{}), then mcp_inspect and mcp_call with server nope → error containing unknown mcp server "nope", Result zero-valued • mcp_list with an empty server → mcp_list: server is req

internal/mcp is at 43.7%. The transport layers (stdio.go is entirely uncovered, pool.go is uncovered except LoadPool) need a fake MCP server and are tracked separately. This issue is the easy half: the pure helpers, which need no server and no network. Add cases (a single helpers_test.go in package mcp is fine) for: truncate (util.go:5) and sanitizeName (util.go:12) — sanitizeName("a/b c") → "a_b_c", sanitizeName("") → "server", boundaries at the max length. (jsonRPCError) Error() (rpc.go:16) — nil receiver and a {-32601, "x"} value. extractToolContent (rpc.go:63) — empty raw → ""; unparseable raw echoed back; only image parts → raw echoed; isError: true text → "error: hello". FormatCallResult (compact.go:109) — maxChars <= 0 falls back to 32000; a short string passes through; an over-long string gets the truncation suffix. LogDir (config.go:46) and CmdLine (config.go:151). Use internal/mcp/rpc_parse_test.go as the template: it is package mcp (internal) and feeds ca

internal/components/layout has no test file and 0.0% statement coverage, yet it is imported by 43 call sites (chat, footer, toast, overlays, composer, configui) for box borders and width-safe truncation. It is a pure package: every function takes a *components.Surface or a string and returns painted pixels / a string. No terminal, no goroutines, no IO. Add internal/components/layout/layout_test.go covering: borderGlyphs — BorderSquare yields ┌┐└┘, BorderRounded yields ╭╮╰╯ DrawRoundedBorder — corners and edges land at the expected buffer offsets on a components.NewSurface(10, 4, nil); w < 2 || h < 2 is a no-op DrawRoundedBorder — a left label wider than the box is truncated and the right label survives TruncateToWidth — ASCII ("abcdef", 3 → "abc"), grapheme-safe non-ASCII ("héllo", 3), max <= 0 → "", and a wide-CJK case BorderLabel.Visible, borderLabelWidth Copy the style from internal/components/chat/chat_test.go (components.NewSurface(w, h, nil), the ro