powsybl/powsybl-core

Describe the current behavior Javadoc and signature of the function: /** * Get a list of temporary limits ordered by descending duration. * @return a list of temporary limits ordered by descending duration */ Collection<TemporaryLimit> getTemporaryLimits(); Describe the expected behavior Javadoc and signature of the function: /** * Get a list of temporary limits ordered by descending duration. * @return a list of temporary limits ordered by descending duration */ List<TemporaryLimit> getTemporaryLimits(); Describe the motivation The javadoc is inconsistent with the actual return type of the function. Our current implementations also guarantee that the limits are ordered by descending duration (as written in the contract of the function). However, there is no ordering relation on a Collection, so this guarantee disappears. Moreover, if we want to get the temporary limit with the highest duration, we need to do getTemporaryLimits().iterator().next() which isn't great (compared to j

Describe the current behavior split() works for some chunk size but fails for others when chunks are not successive. Example chunk1: offset = 0, values = [1, 2, 3] chunk2: offset = 6, values = [7, 8] # timeSeries timeSeries (chunk1, chunk2): [1d, 2d, 3d, NaN, NaN, NaN, 7d, 8d] split(2) works and returns non successive chunks: offset = 0, values = [1, 2] offset = 2, values = [3] offset = 6, values = [7, 8] These chunks are not successive: after offset 2 with size 1, the next expected offset should be 3, not 6. split(3) works also. but split(4) fails with: java.lang.IllegalArgumentException: Chunks are not successive. First offset is 0 and first size is 3; second offset should be 3but is 6 Describe the expected behavior The behavior should be consistent. Either: non successive chunks are supported, and split() should work for all valid split sizes, or non successive chunks are not supported, and split() should fail consistently. Describe the steps Create a time series with two