ndonfris/fish-lsp - Open Source PR Review Scorecard

LSP implementation for the fish shell language 🐠

C-Rank Grade: B (Solid) - 49/100

External PR Merge Rate: 60%

Response Time: -

First Timer Success: 100%

Frequently Asked Questions

Is ndonfris/fish-lsp welcoming to first-time open-source contributors?

ndonfris/fish-lsp has a recorded first-timer success rate of 100.0%. Repositories ranked B typically provide actionable feedback during code reviews and actively nurture new community contributors.

How fast can I expect code review feedback on my pull request?

Maintainers in ndonfris/fish-lsp respond to incoming external pull requests in approximately 0.0 hours on average. Keeping PRs focused on single tasks and ensuring tests pass helps maintainers review faster.

What does the 49.5 C-Rank™ score (B Tier) represent?

The C-Rank™ system evaluates GitHub projects on a 0–100 scale using real data: PR merge rates, review turnaround time, active maintainer presence, and first-time contributor success. A score of 49.5 places ndonfris/fish-lsp in the B tier.

What is the external contributor pull request merge rate for ndonfris/fish-lsp?

The external contributor pull request merge rate for ndonfris/fish-lsp is 60.0%, based on public PR activity from non-core contributors.

Are there Good First Issues available in ndonfris/fish-lsp?

ndonfris/fish-lsp currently has 3 active issue(s) tagged with beginner-friendly labels like "good first issue", "beginner", or "up-for-grabs".

ndonfris
ndonfris/fish-lspB•Solid337
GitHub
Back to Explorer
ndonfris

ndonfris/fish-lsp

337
Active (30d)B•Solid(49/100)Low Sample (<20 PRs)TypeScript

LSP implementation for the fish shell language 🐠

GitHub
Compare••
Jump to:

AI Maintainer Review Guidelines

Review Persona

Empathetic Technical Mentor

Warmth Score
7.5/10
Patience Score
8.2/10
Nitpick Rate
20%

Collaborative maintainer environment in ndonfris/fish-lsp. Reviews community pull requests with focus on project quality.

What Contributors Actually Say

Discussions in ndonfris/fish-lsp focus heavily on practical implementation feedback, code formatting standards, and issue reproduction details.

Hidden Friction Signals

Unlinked PRs without issue context and changes that fail automated test suites face the highest review friction.

Unwritten Rules

  • •1) Keep PR scope strictly aligned with the linked issue.
  • •2) Ensure local linters pass before opening a review.
  • •3) Maintain full test coverage for modified logic.

Top PR Submission Do's

  • •Ensure code complies with the project coding style
  • •Keep PRs scoped to a single concern
  • •Include context and link to the related issue

Top PR Friction Pitfalls (Don'ts)

  • •Do not submit PRs without linking an issue
  • •Do not break existing tests without fixing them
  • •Do not mix unrelated refactors in a single PR
Response Velocity
-
No reviewer activity recorded

Average Response Latency

Tracks hours until a maintainer leaves a review, comment, or PR response.

Merge Efficiency
60.0%
Moderate PR acceptance rate

External Acceptance Rate

Percentage of community pull requests successfully merged into main.

First-Timer Success
100.0%
Strong first-timer PR acceptance rate

First PR Conversion

Rate at which developers submitting their first repository PR succeed.

Active Maintainers
1 core
Single maintainer review bottleneck
Diagnostic Health HUD
60.0%
Merge Gauge
100.0%
1st-Timer
Community Vibe54/100

Embed C-Rank Badge

Show contributors that your repository actively reviews and merges external pull requests.

GetMerged C-Rank badge for ndonfris/fish-lsp
[![GetMerged C-Rank](https://getmerged.abhishekco.de/api/badge/ndonfris/fish-lsp)](https://getmerged.abhishekco.de/ndonfris/fish-lsp?utm_source=github&utm_medium=badge)

Active Good First Issues (3)

View on GitHub

Summary Parse abbr definitions from fish configs and convert to CompletionItem snippets with proper tabstops and cursor positioning. Abbreviations are currently invisible to the language server. This feature would bring them into the IDE completion workflow. NoteEarly releases of fish-lsp included abbr in CompletionList which might be useful for reference. Eventually abbr CompletionItems were removed once newer flags were shipped which complicated naive parsing (e.g., --position=anywhere, --function, --regex). Ignoring complex cases of abbr definitions is acceptable for an initial implementation, with the goal of covering the most common/basic use-cases first. Scope Possible approaches: parse any abbr command in fish workspace (possibly only: ~/.config/fish/{config.fish,conf.d/*.fish}) parse abbr --show child_process output during startup (initial approach used this) Flags to consider: -a/--add name and expansion to abbr --set-cursor=[VALUE] use value, but default to % --position a

📅 Opened Jun 18, 2026💬 0 comments
Quality: 80/100Contribute

Describe the bug I expected to get LSP working with the following setup in VS Code: { "workbench.colorTheme": "Light 2026", "nushellLanguageServer.nushellExecutablePath": "C:\\Program Files\\nu\\bin\\nu.exe", "security.workspace.trust.untrustedFiles": "open", "chat.disableAIFeatures": true, "fish-lsp.executablePath": "C:\\Users\\Huawei\\AppData\\Roaming\\npm\\fish-lsp", "fish.path.fish": "C:\\tools\\cygwin\\bin\\fish", "fish.path.fish_indent": "C:\\tools\\cygwin\\bin\\fish_indent" } To Reproduce Open fish file, try type cat -- and press TAB to get no LSP completions, while I expected to get the same suggestions as I get in interactive Fish shell session: Expected behavior Suggestions as I get in interactive Fish shell session. Screenshots If applicable, add screenshots to help explain your problem. OS NAME: Cygwin fish: Unknown command: yarn in command substitution fish: Unknown command echo "YARN VERSION: $(yarn --version)" ^ NODE VER

📅 Opened May 31, 2026💬 5 comments
Quality: 45/100Contribute

Describe the bug set -l options 'v/verbose' argparse $options -- $argv fish-lsp says: Unused local variable '_flag_$options' is defined but never used. (4004) To Reproduce copy above 2 lines to a file, open in helix or editor with lsp enabled Expected behavior fish-lsp should evaluate the value of $options Please complete the following information: OS NAME: Darwin YARN VERSION: 1.22.22 NODE VERSION: v25.6.0 FISH VERSION: fish, version 4.4.0 FISH-LSP VERSION: 1.1.3

📅 Opened Feb 7, 2026💬 4 comments
Quality: 45/100Contribute
Looking for more TypeScript beginner tasks?Explore TypeScript GFI

Contributor Community Vibe Feedback

Rate what actually matters after opening a pull request here.

Have you contributed to this repo?

Rate your first-hand PR experience (review speed, maintainer responsiveness, and onboarding ease) to help other contributors.

3 ratings required
Maintainer helpfulness
Review speed
Beginner friendliness

Contributor Compatibility & Review Speed Analysis for ndonfris/fish-lsp

When evaluating whether to contribute to ndonfris/fish-lsp, response velocity and maintainer engagement are crucial. GetMerged continuously tracks pull request trajectories, first-comment latency, and code review rounds to help developers avoid submitting pull requests to backlogged repositories.

Currently, maintainers of ndonfris/fish-lsp acknowledge new external contributions in approximately -. Out of all submitted pull requests from non-core authors in the last 180-day window, 60.0% were successfully merged into the primary branch.

Frequently Asked Questions - Contributing to ndonfris/fish-lsp

01

Is ndonfris/fish-lsp welcoming to first-time open-source contributors?

ndonfris/fish-lsp has a recorded first-timer success rate of 100.0%. Repositories ranked Solid typically provide actionable feedback during code reviews and actively nurture new community contributors.

02

How fast can I expect code review feedback on my pull request?

The initial maintainer response time averages ~-. Keeping PRs scoped to single concerns and ensuring CI checks succeed will optimize review turnaround.

03

What does the 49.5 C-Rank™ score represent?

The C-Rank™ index scores repositories on a 0 to 100 scale using an objective formula: external PR merge rates, initial response speed, active maintainer count, and first-time contributor retention. A score of 49.5 places ndonfris/fish-lsp in the Solid tier.

04

What is the external contributor pull request merge rate for ndonfris/fish-lsp?

The external pull request merge rate is 60.0%. GetMerged isolates non-core community contributions so external developers get an accurate benchmark of PR acceptance probability.

05

Are there beginner Good First Issues open in ndonfris/fish-lsp?

Yes, ndonfris/fish-lsp currently has 3 active issue(s) tagged with beginner-friendly labels. You can inspect these directly from the repository issues tab.

GetMerged C-Rank™ Indexing Standard

All metrics displayed for ndonfris/fish-lsp are automatically retrieved via the public GitHub API and recalculated daily. Insider pull requests submitted by repository owners or organization members are excluded from merge rate calculations to preserve objective external contributor statistics.