liquidmetal-dev/flintlock

Describe the solution you'd like: The code of the e2e tests should be linted in CI. make lint does not look at test/e2e, for two reasons: All of the files have the e2e build tag, and the linter runs without it. .golangci.yml has tests: false, which skips the _test.go files. So the lint check of a PR passes whatever is in test/e2e. What is needed: A second run of the linter with --build-tags e2e for ./test/e2e/..., in make lint or as its own target, so that it is part of the lint workflow. The findings which are there today fixed, or excluded with a reason. A decision on the _test.go files of the e2e package, see below. Why do you want this feature: The harness is about 800 lines of Go which run as root, start daemons and remove directories. It should be held to the same rules as the rest of the code. #1254 found 7 things in the code which it added, and only because the linter was run by hand. Anything else you would like to add: The state at #1254 (b87591e), with golangci-lint run

Describe the solution you'd like Correct the ADR numbering instruction in CONTRIBUTING.md, which describes a convention the project stopped following four years ago. CONTRIBUTING.md:622-628 says: Once a decision has been made, open a PR adding a new ADR to the directory. Copy and complete the [template][adr-template]; Increment the file number by one Actual practice is that the four-digit prefix is the GitHub Discussion number: File Discussion 0234-update-api.md #234 0241-opinionated-api-changes.md #241 0246-linters.md #246 0284-testing-standards.md #284 Only 0001–0005 are sequential, and the jump from 0005 to 0234 is the convention changing. Every ADR since has used the discussion number, which makes sense given the same section requires opening the discussion first. Why do you want this feature A contributor following the written instruction literally would name their file 0006-..., which collides with nothing but is inconsistent with everything added since 2021

Describe the solution you'd like Document how to configure TLS, mTLS and (once #7 lands) identity. Current state Authentication and TLS are effectively undocumented. Grepping all of userdocs/docs for tls|auth|token|cert|insecure|mtls|security returns three hits, all incidental and all in getting-started/flintlock.md: line 40, the bare --insecure flag in the quickstart command, with no explanation of what it disables; lines 58-59, the expected startup output, which is just the two warnings: WARN[0000] basic authentication is DISABLED WARN[0000] TLS is DISABLED There is no page explaining how to enable TLS, how to enable mTLS, how to generate or supply certificates, what the token format is, or how a client should send it. Two guides that should cover this are empty stubs: userdocs/docs/guides/production.md — _Coming soon..._ userdocs/docs/guides/client.md — also _Coming soon..._, and mis-titled Production, which looks like a copy-paste leftover and should be fixed while we are