google/adk-go

🔴 Required Information Describe the Bug: A task-mode agent whose OutputSchema is a nullable non-object type can finish with a null result, and when it does, the coordinator never receives the result and is never resumed. No error is reported. When the task agent's OutputSchema is not an object, finish_task wraps it under a required result key (finish_task_tool.go#L76-L83). Since #1566, a schema with Nullable: true accepts finish_task({"result": null}), and the task model is told "Task completed.". runTask then copies that nil into the event's output (llm_agent_wrapper.go#L704-L706). The coordinator treats a nil output as "the task did not finish" and returns without a function response (llm_agent_wrapper.go#L597-L618), so the delegation stays open. Links are pinned to main at 65761912. Steps to Reproduce: Save the test below as agent/llmagent/repro_null_task_result_test.go. It uses the package's existing scriptedLLM test helper. Run go test -count=1 -run TestReproNullableTaskResult

What Add a toolset that reads an OpenAPI 3.x document and exposes each operation as an ADK tool, so an agent can call a REST API described by its spec without anyone hand-writing a functiontool per endpoint. Target import path: google.golang.org/adk/tool/openapitoolset. Why adk-python has had this since early on, as google/adk/tools/openapi_tool (openapi_toolset.py, operation_parser.py, rest_api_tool.py). adk-go has no equivalent, so anyone pointing an agent at an existing REST API has to write the wrappers by hand. #451 attempted it and we closed it: it was stacked on two auth PRs that did not land, and its hand-rolled parser skipped $ref rather than resolving it. The goal here is a much smaller change that reuses what main already provides. Design constraints These come from decisions already made in the repo, so a PR that ignores them will not land. Credentials go through auth.CredentialProvider. Main's auth package resolves one credential per invocation and auth.Transport is an ht

Problem Spelling in comments and strings is inconsistent across the repo. main today carries 60 cancelled, 26 behaviour, 19 synthesised, 8 marshalling and a long tail of British and misspelled forms — 200 hits across 67 Go files by misspell -locale US. Nothing enforces this, so it drifts back as fast as anyone fixes it. #741 tried a manual sweep in April; by now main has moved 182 commits and reintroduced most of what it fixed. A one-time pass is not the answer here. Proposal Add misspell to .golangci.yml, then land the mechanical sweep it produces: linters: enable: - goheader - revive - misspell settings: misspell: locale: US Two changes, ideally as two commits: the sweep, then the linter that keeps it. Decisions already made whitespace stays one word. The Go wiki lists "white space", but the standard library uses the single word about 3:1 — 222 against 74 in the go1.26 src tree, excluding testdata and vendor. misspell does not flag it either way, so no

Problem The Nightly workflow is triggered daily through schedule. When GitHub Actions schedules are enabled on a fork, the workflow also runs there and consumes runner resources for module discovery, race tests, and vulnerability checks. Manual workflow_dispatch runs on forks should remain available. Proposed solution Guard the root discover job so scheduled executions run only in the upstream repository: if: github.event_name != 'schedule' || github.repository == 'google/adk-go' The test and vulncheck matrix jobs already depend on discover, so they will also be skipped when a scheduled run occurs on a fork. Expected behavior Scheduled Nightly runs execute in google/adk-go. Scheduled Nightly runs allocate no runners in forks. Manual workflow dispatch continues to work in forks. Push and pull-request behavior remains unchanged.

The new func (s *gcsService) GetArtifactVersion(ctx context.Context, req *artifact.GetArtifactVersionRequest) method does not appear to be covered by the contract tests yet. adk-go/artifact/request_validation_test.go Line 329 in b8eb8c5 func TestGetArtifactVersionRequest_Validate(t *testing.T) { It would be useful for the contract tests to define which ArtifactVersion fields are required across backends, which are optional, and whether backend-specific omissions are allowed.