Good First Issues in Smalltalk

the rule may report initialize methods as having problems and this is not correct. Here is a possible solution basicCheck: aMethod (aMethod numArgs > 0 or: [ aMethod isAbstract ]) ifTrue: [ ^ false ]. (aMethod protocolName beginsWith: 'accessing') ifFalse: [ ^ false ]. (aMethod selector = #initialize) ifTrue: [ ^ false ]. ^ aMethod ast withAllChildren noneSatisfy: [ :each | each isReturn ]

Bug description when calling PragmaCollector>>release an exception is thrown. To Reproduce | p | p := PragmaCollector new. p release Expected behavior the code should execute without bug Screenshots If applicable, add screenshots to help explain your problem. Version information: OS: all Pharo Version 14 Solution the method from Model class (which was previously the super class) destroyAnnouncer was not in the Pharo image. adding the method in PragmaCollector>>destroyAnnouncer solves the problem destroyAnnouncer announcer := nil.

We should deprecate selectorsWithArgs: numberOfArgs "Return all selectors defined in this class that take this number of arguments" <reflection: 'Class structural inspection - Selectors and methods inspection'> ^ self selectors select: [:selector | selector numArgs = numberOfArgs]

String does not have to be 'polymorphic' with the test of the world asString makes sense in Date, DateAndTime, Time but not in String. We should deprecate it.

The , message is typically used to concatenate ordered collections such as arrays or strings. Its expected behavior is to return a sequential, ordered concatenation of the receiver and the argument. However, a Set does not preserve order by definition. Because of this, supporting the , message on Set introduces semantic inconsistency: the operation suggests ordered concatenation, while sets are unordered collections. Proposed change The Set class should not implement or respond to the , message. Users should call the union: method explicitly.

inspectionRichText <inspectorPresentationOrder: -1 title: 'RichText'> ^ MicTextPresenter new text: self The inspector raises an error because we should rewrite the method with an extra parameter. WOuld have been great to not push extra works to users of inspector. Automatically adding a parameter a a method is simple and it should have been a better approach.