dyoshikawa/rulesync

Summary Please add support for Poolside as a generation target. Poolside's coding agent is pool — a single binary that runs an interactive TUI in the terminal and also acts as an Agent Client Protocol (ACP) server, so it is driven from Zed, JetBrains, Neovim and other ACP-compatible editors as well as from the CLI. Repo: https://github.com/poolsideai/pool Docs: https://docs.poolside.ai (LLM doc index: https://docs.poolside.ai/llms.txt) CLI overview: https://docs.poolside.ai/cli/pool Install: https://docs.poolside.ai/cli/install Why Poolside exposes most of the primitives rulesync already fans out — rules, skills, MCP, subagents, hooks and permissions — and it does so on top of two conventions rulesync already handles: it reads AGENTS.md for instructions, and its skills follow the Agent Skills specification that rulesync's agentsskills target already enforces. So a fair amount of the plumbing exists. Being honest about demand: this is one user asking. I keep a single source of t

JSON.stringify(stripControlCharacters(x)) is now the way a remote-derived name reaches a log line, and it is spelled out at roughly 28 call sites across src/ — 20 of them in src/lib/fetch.ts after #2841. src/types/dir-feature-processor.ts additionally hoists it into quoted* locals, so two spellings of the same idiom coexist. The order matters and is not self-evident: the strip has to run first, because JSON.stringify escapes quotes and backslashes but not the C1 range or the bidi controls. That rationale currently lives in a comment at one call site. Suggested shape: export a quoteForLog(text: string): string from src/utils/control-characters.ts that does both, carry the ordering rationale in its doc comment, and replace the call sites with it. Mechanical, and it gives the convention one home to point at when the next log line is written. Found during the review of #2841.

Background RulesyncMcp.getMcpServers() deliberately strips tool-specific keys so that a key meant for one target never leaks into another target's config. Targets that own one of those stripped keys therefore have to read it back off the unfiltered JSON, and three adapters now repeat the exact same lookup: src/features/mcp/codexcli-mcp.ts:562 — envVars, experimental_environment src/features/mcp/musecode-mcp.ts:320 — musecodeMode src/features/mcp/rovodev-mcp.ts:652 — rovodevEnableInstructions / enable_instructions Each one writes its own variant of: const rawMcpServers = rulesyncMcp.getJson().mcpServers; const rawServer = isRecord(rawMcpServers) && Object.hasOwn(rawMcpServers, name) ? rawMcpServers[name] : undefined; This was raised as a low finding during the review of #2793 and intentionally deferred there, because hoisting it would have touched codex and musecode, which are unrelated to the issue that PR closed (#2767). Proposal Add a single accessor on RulesyncMcp,