drogonframework/drogon

cppcheck warned about this function: https://github.com/drogonframework/drogon/blob/master/orm_lib/inc/drogon/orm/SqlBinder.h#L355 if it's neither traits::isExceptCallback nor traits::isSqlCallback, nothing is returned

Description When a PostgreSQL connection is lost, Drogon automatically attempts to reconnect every 1 second. This can cause unnecessary CPU usage, connection attempts, and excessive logs when PostgreSQL is unavailable for an extended period. I am using Drogon v1.9.13. Current behavior In orm_lib/src/DbClientImpl.cc, the reconnect is scheduled with: loop->runAfter(1, [weakPtr, loop, closeConnPtr] { ... }); As a result, when PostgreSQL is down, I see logs like: Pg connection failed Pg connection failed Pg connection failed Pg connection failed approximately every second for each connection in the pool. Expected behavior It would be useful to have a configurable reconnect interval, for example: "reconnect_interval": 5 The default could remain 1 second for backward compatibility. Suggested implementation Instead of hard-coding: loop->runAfter(1, [weakPtr, loop, closeConnPtr] { ... }); the reconnect delay could be stored in the database client configuration: loop->runAfter(reconne

Notice If you need support or clarification regarding the usage of Drogon in your project, visit the official Drogon support channel at gitter Please create a new issue only if you think you have found a bug or if have a feature request/enhancement. Describe the bug trantor::EventLoopThread::~EventLoopThread() calls thread_.join() on its own worker thread as part of normal teardown. If the last shared_ptr<drogon::orm::DbClientImpl> reference is released from inside a callback already executing on that same DbLoop thread (in our reproduction: PgConnection::handleRead() → DbClientImpl::makeTrans's cleanup lambda), the resulting destructor chain (~DbClientImpl → ~EventLoopThreadPool → ~EventLoopThread) runs on the thread it's about to try to join. std::thread::join() correctly detects this self-join (get_id() == std::this_thread::get_id()) and throws std::system_error(std::errc::resource_deadlock_would_occur) — uncaught, since nothing in DbClientImpl's teardown path expects a dest

🐛 Bug Report: MultiPartParser Fails with Dash-Prefixed Boundaries (Firefox Compatibility) 📄 Description The MultiPartParser fails to correctly identify the first part of a multipart/form-data request when the boundary string in the Content-Type header begins with multiple dashes. This is a common scenario with Firefox (Gecko-based) browsers, which generate boundaries like: ----geckoformboundary... ⚙️ Technical Root Cause In lib/src/MultiPart.cc, the method: parse(const HttpRequestPtr &req) extracts the raw boundary string from the header and searches for it directly in the request body. However, per RFC 7578, the actual delimiter in the body is: "--" + boundary Example: Boundary: ----ABC Actual delimiter: ------ABC Because of this: The parser searches for ----ABC But the body contains ------ABC The match is found starting at offset +2 instead of index 0 This introduces a 2-byte offset error. As a result: parseEntity() begins parsing from the wrong position Expected \r

Is your feature request related to a problem? Please describe. When I needed to add a query parameter to a HttpRequest, I used setParameter("key", "value"), which worked as expected when the method was GET, but when the method is POST and the content type is multipart/form-data, setParameter adds the parameter to the body. I also tried to add the query parameter manually via setPath("/endpoint?key=" + value), and since value has a space in it, I ended up using setPath("/endpoint?key=" + utils::urlEncodeComponent(value) (just like in the HttpRequest implementation) but for some reason that did not work As I was writing this I found out that setPath() automatically encodes the path (maybe add something like "(see setPathEncode())" to the setPath doc comment) and it worked, but I'd prefer setQueryParameter as you could keep it consistent across requests, independent of the HTTP method Describe the solution you'd like I'd like to have either an overload for setParameter to explicitly speci