community-shaders/skyrim-community-shaders

When using CS v.1.4.6 some meshes have their snow shader applied incorrectly. The screenshots were taken without any mods modifying the meshes or textures (not even using SMIM). I could find two examples so far: Windhelm Bridge Revived: as seen in the first image, the wood planks don't get the snow shader applying correctly. I played around with In-game patcher to rotate the mesh and the shader seem to work in the position seen in the second screenshot. Capital Windhelm Expansion: this particular mesh seems to be getting snow even when fully vertical. By rotating the mesh in-game I noticed that if you flip the mesh while keeping it vertical, the snow shader doesn't apply. An additional issue is that shader doesn't apply when the mesh is slightly tilted as seen in the screenshots. Windhelm Bridge Revived Capital Windhelm Expansion

Problem Similar to #1751, multiple features hook SetupGeometry independently, creating redundant vtable hook chains in a hot path called for every render pass (thousands of times per frame). Features hooking BSLightingShader::SetupGeometry: TruePBR (core) Hooks.cpp core extensions LightLimitFix SubsurfaceScattering LinearLighting ExtendedTranslucency FrameAnnotations Features hooking BSEffectShader::SetupGeometry: Hooks.cpp core extensions LightLimitFix FrameAnnotations Features hooking BSGrassShader::SetupGeometry: Hooks.cpp core extensions GrassCollision FrameAnnotations Each feature patches the same vtable slot (0x6), creating a chain of virtual dispatches. With 10+ hooks, this creates unnecessary overhead. Proposed Solution Add new Feature lifecycle hooks following the pattern from #1751: virtual void SetupGeometry_Lighting(RE::BSRenderPass* pass, uint32_t flags) {} virtual void SetupGeometry_Effect(RE::BSRenderPass* pass, uint32_t flags) {} virtual void SetupGeometry_Grass

Description The code currently uses a hardcoded memory offset (0x38LL) to access the enableWaterTAA member in the BSImagespaceShaderISTemporalAA structure: bool* enableWaterTAA = reinterpret_cast<bool*>(reinterpret_cast<uintptr_t>(BSImagespaceShaderISTemporalAA) + 0x38LL); Location: src/Features/Upscaling.cpp:705 Tasks Investigate if CommonLibSSE/CommonLibVR has already reverse engineered the BSImagespaceShaderISTemporalAA structure. We use the ng branch of commonlibvr. If available in CommonLib, refactor to use the proper structure member instead of hardcoded offset If not available, perform RE work to properly define the structure Document the structure definition for maintainability Context Hardcoded offsets are fragile and can break with game updates or across different game versions. Using proper structure definitions from CommonLib (if available) or creating our own RE definitions would make this code more maintainable. References PR: https://github.com/doodlum/skyrim-comm