beetbox/beets

Problem With synced: yes, the lyrics plugin sometimes stores plain lyrics even though LRCLIB has valid synced lyrics for the exact track. The log says 🟢 Found lyrics, but the synced version is silently discarded. Cause LRCLyrics.verify_synced_lyrics (beetsplug/lyrics.py) only looks at the last line of the LRC text: m := Lyrics.LINE_PARTS_PAT.match(lyrics.splitlines()[-1]) Some LRCLIB entries end with an extra blank line (...\r\n\r\n). Then splitlines()[-1] == "", LINE_PARTS_PAT (^(\[\d\d:\d\d\.\d{2,3}\]|) *(.*)$) matches the empty string with an empty timestamp group, if ts: is false, the method returns None, and the candidate falls back to plainLyrics. Reproduction (beets 2.14.1, also unchanged on master) LRCLIB record id 38757983 (Carly Rae Jepsen – "Blue Skies", duration 149 s): from beetsplug.lyrics import LRCLyrics lrc = "[00:17.23]I said \"I love you\" first\r\n[02:23.59]Feel it every time you are around\r\n\r\n" print(LRCLyrics.verify_synced_lyrics(149.0, lrc)) #

Hi! New to beets. Tried renaming a bunch of album artists at once, the search results were too broad however. Using the 'select' option after to narrow down the albums resulted in a stringified object being used as the album artist name. I can't re-do this command since I accepted the changes thinking it was just a bug on the UI side, but it did in fact change the artist in the data as well. Problem $ beet modify -a 'Ye' albumartist='Kanye West' Led to this problem: [...] Ye - 808s & Heartbreak albumartist: Ye -> Kanye West [...] Really modify, move and write tags? (Yes/no/select) select [...] Ye - 808s & Heartbreak albumartist: Ye -> ModifyOperation(operator=None, value='Kanye West') Setup OS: macOS Tahoe Python version: 3.14.7 beets version: 2.13.1 Turning off plugins made problem go away (yes/no): no My configuration (output of beet config) is: directory: ~/music-beets # --------------- Main --------------- library: ~/beets-data/musiclibrary.db import: move: yes # -

Problem Beets stores authentication/token files that may contain sensitive credentials. These files should not be readable or writable by other users on the system. Currently, token files may be created using the default filesystem permissions, which can result in permissions that are more permissive than intended depending on the user's umask. Expected behavior Token files should always be created with permissions: 0600 This means: Owner: read + write Group: no access Others: no access The implementation should explicitly set the file mode rather than relying solely on the process umask. Proposed solution When creating or writing token files, ensure they are created with 0600 permissions. Ideally, the file should be created atomically with the desired mode to avoid a window where the file has broader permissions. For existing token files, consider restricting their permissions to 0600 when they are accessed or updated.

Problem The Tidal plugin does not appear to honor tidal.search_limit. With a config such as: tidal: search_limit: 1 Tidal album and track searches still return (at least 20+) results. Expected behavior Tidal should cap album and track search candidates using the configured search_limit, matching the behavior of other metadata source plugins. Likely cause Tidal implements candidates() and item_candidates() directly, then calls api.search_results() from search_albums_by_query() and search_tracks_by_query(). That bypasses the shared search path that reads search_limit into SearchParams.limit. Suggested fix Thread search_limit through the Tidal query search path, or truncate returned Tidal relationships before resolving album/track IDs. Add focused tests for both album and track search with search_limit: 1. Tagging @semohr for visibility.

Proposed solution Add a new command subsonicupdate (no arguments) which will trigger a library update for the configured Subsonic server. Add a new plugin config parameter auto (boolean, defaults to `false). When this option is enabled the update request won't be made automatically with library or smart playlist updates. Objective Goals To allow updating Subsonic library explicitly, for example if the library is on another machine and is independent of the main Beets library Non-goals Anti-goals Nothing should break since the new auto config entry would be false by default which maintains the existing behaviour.