apache/lucenenet

Is there an existing issue for this? I have searched the existing issues Task description There are currently several issues with the implementation of FileSupport.GetCanonicalPath(), which is mostly a port from Apache Harmony. This method is on a required path for nearly all users, so it would be good to ensure that it is optimized and fully functional. No guard clause for null check, which should throw ArgumentNullException Logic is allocating 1 extra byte to the temporary array, appending a 0 byte at the end, converting to string, then removing the trailing \0 character that the 0 byte creates. It would be better just to omit the null character from the buffer. The part that resolves symbolic links was not ported (there is a LUCENENET TODO for it in the code). The behavior of the GetOrAdd() method already allows racing threads to both run the business logic without blocking. If we move the logic that builds the string into the factory parameter of this method, we can elimina

Very minor issue for potential clean up and standardisation. Searching the codebase finds: 21 for <?xml version="1.0" encoding="UTF-8"?> 90 for <?xml version="1.0" encoding="utf-8"?> 2 for <?xml version="1.0"?> 120 for <?xml version="1.0"... From Google below The short answer is no, it doesn't need to be capitalized, but it can be. According to the official W3C XML specifications, character encoding names are case-insensitive. That means XML parsers will treat all of the following exactly the same way: encoding="utf-8" (Most common) encoding="UTF-8" (Also very common) encoding="Utf-8" Best Practices While both work perfectly, utf-8 (lowercase) or UTF-8 (uppercase) are the widely accepted standards. Here is why developers generally lean toward one or the other: Lowercase (utf-8): This is the default output for many modern web frameworks, tools, and build engines. It keeps the string uniform with the rest of your lowercased XML attributes (like version="1.0"). Uppercase (UTF-8): T

Is there an existing issue for this? I have searched the existing issues Task description The SonarCloud quality gate issues have been failing on master for some time; we should get those resolved or suppress them as needed. The latest run shows: Failed conditions 16 Security Hotspots E Security Rating on New Code (required ≥ A) C Reliability Rating on New Code (required ≥ A)