Open-J-Proxy/ojp

Affected file ojp-jdbc-driver/src/main/java/org/openjproxy/jdbc/Savepoint.java Java private T retrieveAttribute(CallType callType, String attrName, Class returnType) throws SQLException { ... return (T) result; // unchecked cast } Expected fix Use the generic form of Class: Java private T retrieveAttribute(CallType callType, String attrName, Class returnType) throws SQLException { ... return returnType.cast(result); } How to verify Run mvn checkstyle:check and mvn clean compile — must pass with no new warnings.

Affected files ojp-server/src/main/java/org/openjproxy/grpc/server/utils/PropertyPlaceholderResolver.java ojp-jdbc-driver/src/main/java/org/openjproxy/grpc/client/HealthCheckConfig.java Both contain: Java private static final Logger log = LoggerFactory.getLogger(TheClass.class); Expected fix Remove the field and add the @slf4j annotation at the class level, consistent with the rest of the codebase: Java @slf4j public class PropertyPlaceholderResolver { // no manual logger field needed } How to verify Run mvn checkstyle:check and mvn clean compile — both must pass.

Affected file ojp-jdbc-driver/src/main/java/org/openjproxy/jdbc/Constants.java Java public static final List EMPTY_PARAMETERS_LIST = new ArrayList<>(); public static final List EMPTY_OBJECT_LIST = new ArrayList<>(); Problem Any caller can call .add() or .clear() on these lists and corrupt the shared state for all other callers. The intent is clearly to provide an immutable empty list. Expected fix Replace both with immutable equivalents: Java public static final List EMPTY_PARAMETERS_LIST = Collections.emptyList(); public static final List EMPTY_OBJECT_LIST = Collections.emptyList(); Or, since the project compiles to Java 11+: Java public static final List EMPTY_PARAMETERS_LIST = List.of(); public static final List EMPTY_OBJECT_LIST = List.of();

Affected file ojp-server/src/main/java/org/openjproxy/grpc/server/utils/DateTimeUtils.java Line 29: Java log.info("raw object class: " + rawObject.getClass().getName()); Problems Using log.info for what is clearly a debug statement will spam production logs. String concatenation in log calls is discouraged (should use {} placeholders).

Summary Refactor classes to clean up Sonar Lint issues Context There are many code smells and possible improvements detected by Sonar Lint. Task Analyze the project files using Sonar Lint, mainly StatementServiceImpl, and implement the suggested fixes when possible. Acceptance Criteria No complex or brain methods No unused import No unused variable No redundant code No code smell Code compiles successfully Existing tests pass No functional changes (pure refactoring)