NovaCode37/Prism-platform

The MAC lookup endpoint (/api/mac, web/app.py around line 1146) predates module_status and treats every non-200 from macvendors.com the same way: elif resp.status_code == 404: return {"mac": normalized_mac, "vendor": None, "error": "Not found", "source": "api"} else: return {"mac": normalized_mac, "vendor": None, "error": f"API returned status {resp.status_code}", "source": "api"} What that causes: 404 is an answer, not a failure. macvendors returns 404 when the OUI is not registered (random and locally administered MACs hit this all the time). Because error is set, the Mac panel in ToolPanels.tsx shows a red error card, even though it already has a toolPanels.mac.notFound string for exactly this case. 429 looks like a broken tool. The free API allows about one request per second. Two lookups in a row give "API returned status 429" in red, with nothing saying "wait a second and retry". MODULE_PROXY is ignored. The request is _requests.get(...) with no proxies=get_proxies(), un

modules/onion_checker.py returns zero results for every target, and the scan shows that as a clean "nothing found". >>> o = OnionChecker(timeout=15) >>> len(o._search_ahmia("bitcoin")), len(o._search_darksearch("bitcoin")) (0, 0) Two separate causes: Ahmia now puts a hidden field on its home page (<input type="hidden" name="85f590" value="986a59">, the name and value rotate). A request to /search/?q=... without that pair gets a 302 back to /. requests follows it, parses the home page, finds no <li class="result"> blocks and returns []. With the pair added, the same search returns a normal results page. DarkSearch is gone. darksearch.io does not resolve any more, so _search_darksearch always lands in its except branch. Both failures are swallowed, so nothing tells the user the module did not actually search. What to do: In _search_ahmia, first GET https://ahmia.fi/, read the hidden input's name and value, and pass it as an extra query parameter on the search request (use one request

dataclasses-json is listed in both requirements.txt and requirements-web.txt, so it is installed into the published image, but nothing imports it: git grep -n "dataclasses_json\|dataclass_json\|DataClassJsonMixin" # no matches It has been there since the 2.0 rewrite in March. While you are in these files, requirements.txt also carries the test tooling (pytest, pytest-cov, pytest-asyncio), which a source install does not need to run PRISM. What to do: Remove dataclasses-json from both files. There is a test that fails when the two files disagree on a shared package, so change them together. Move pytest, pytest-cov and pytest-asyncio into a new requirements-dev.txt, and install it in .github/workflows/ci.yml alongside the main requirements. Mention requirements-dev.txt in the contributing notes where the test command is described. Done when CI passes with the slimmer runtime requirements and pip install -r requirements.txt no longer pulls test tooling.

Two strings are still English in every non-English locale, because the English text was copied into each file and never translated: topbar.getFirefoxExtension "Get the Firefox extension" results.json.copyRawJson "Copy raw JSON" They are easy to miss: npm run test:i18n checks that every locale has the same keys, and it has no way to notice that a value is identical to the English one. What to do: Translate both keys in the nine non-English files by hand. Extend frontend/scripts/test-i18n-keys.mjs so it fails when a non-English value is identical to the English one and contains at least two words. Short technical strings (DNS, ASN, JSON, SPF · DKIM · DMARC) are legitimately the same everywhere, so keep an allowlist for the few that trip the rule. Done when the check runs in CI, passes on main, and fails if someone copies an English sentence into a locale file.

Since #525, a GitHub username that does not exist is reported as ok with status_reason: "GitHub user not found", which is the right status: the lookup worked and the answer is "no such user". The frontend has not caught up. In ScanResults.tsx the GitHub card is a KeyModuleCard, and KeyModuleCard only renders status_reason for skipped, rate_limited and error. For ok it renders the children, so a missing user now shows a card of empty rows (Name, Type, Bio, Company, ...) and "Repos: not checked", with nothing saying why. What to do: When r.github is ok and r.github.profile is empty, render the reason (or a translated "No GitHub user with this name") instead of the field list. Put the text in messages/*.json under results.github, in all ten locales; npm run test:i18n checks they line up. Keep the card itself, so the user can still refresh the module. Done when scanning a username that has no GitHub account shows one clear line in the GitHub card instead of empty fields.