LargeModGames/spotatui

What docs/scripting.md says an empty field in a plugin table is nil: id (nil for local tracks), image_url, release_date, volume_percent, device, currently_playing and more. It is not nil. The snapshots reach Lua through lua.to_value, and mlua 0.12's default SerializeOptions has serialize_none_to_null: true. So every None becomes the light userdata null value, the same one spotatui.json_decode("null") gives, and that value is truthy in Lua. No type in src/core/plugin_api.rs has skip_serializing_if, so this applies to every Option field. A plugin that follows the docs breaks: local t = spotatui.current_track() if t.release_date then local year = t.release_date:sub(1, 4) -- error on a track with no date end I checked it on main at c250ac6: for a playback table with no device, type(p.device) is userdata, p.device == nil is false, and p.device and true or false is true. The fix is to make the code match the docs, so an empty field is nil. Where to look src/infra/scripting/api.rs: the lua

What Every Subsonic track comes in with track number 0. The Subsonic and OpenSubsonic song object (Child) sends the album track number as track, but SubsonicSong deserializes a key called trackNumber. No real server sends that key, so on Navidrome, Gonic or Airsonic the field is always missing and song_to_track_info falls back to 0. To see it, pick the Subsonic source, add - { id: index } to tables.songs in config.yml (docs/configuration.md lists index as an extra id for songs) and open any Subsonic playlist. The index column shows 0 on every row. Expected: each song's album track number as the server sends it (for example 5, 1, 12). The column prints the album track number, not the position in the playlist. The existing unit tests don't catch it because their JSON fixtures use the same wrong trackNumber key. Where to look SubsonicSong in src/infra/subsonic/types.rs: #[serde(rename = "trackNumber", default)] on track_number (lines 143-144) SubsonicSource::song_to_track_info in src/inf

What LRC lyrics can start with header tags like [ar:Queen], [ti:Song], [by:someone] or [offset:+500]. The doc comment on parse_synced_lyrics says lines without a valid timestamp are dropped, but the parser reads the minutes, seconds and fraction with unwrap_or(0), so a tag is kept as a lyric line instead: [ar:Queen], [ti:Song], [by:someone], [la:en] and [offset:-500] each become (0, ""), a blank row at the top of the lyrics view. [offset:+500] (or [offset:500]) is worse. "offset" fails and counts as 0 minutes, but Rust's u64 parser accepts +500, so the tag becomes (500_000, ""): a blank line at 8:20. The parser doesn't sort, and active_lyric_index stops at the first entry later than the current position. So a header like [ar:X], [ti:Y], [offset:+500] followed by normal timed lines keeps the highlight stuck on a blank line until 8:20, which on most tracks means the whole song. A syncedLyrics body that only has tags counts as synced lyrics made of blank lines, so the plainLyrics fallbac

What #600 made the playlist sort ignore letter case, but only for the full track table. The in-playlist search (Ctrl+f on a playlist's track table) re-sorts its matches with its own function, and that one still compares raw Strings, so every capitalised title lands before every lowercase one. To see it, open a playlist that has apple, Banana and cherry in it by the same artist. Press , then n to sort by Name, then press Ctrl+f and search for the artist's name. The results come back as Banana, apple, cherry. They should come back as apple, Banana, cherry, the same order the sorted table shows without the search. Sorting by Artist or Album has the same problem in the search results. Where to look sort_playlist_track_matches at the top of src/core/app/playlist_pages.rs (lines 3 to 24): the SortField::Name, SortField::Artist and SortField::Album arms compare the raw fields Its only caller, App::apply_playlist_track_search_results in the same file (the call is at line 201) The fixed versio

What The listening recap splits the top track's name on the first -, so a track with - in its title loses half the title to the artist slot. Spotify titles do this a lot: Bohemian Rhapsody - Remastered 2011, Tsunami - Radio Edit. If one of those is your most-played track, press R (the generate_recap key; on the Stats screen it uses the selected period, anywhere else Last 30 Days) or run spotatui history recap, then open the HTML file. The share card shows the track as Bohemian Rhapsody and the artist as Remastered 2011, with no Queen anywhere, and the card's iTunes cover lookup searches for Bohemian Rhapsody Remastered 2011. The Top Tracks list further down shows Bohemian Rhapsody - Remastered 2011 - Queen as one bold line with no artist line under it. Top Albums and Top Artists go through the same split: an album called Live - 1985 shows Live in bold with 1985 styled as its artist. Expected: the card says Bohemian Rhapsody - Remastered 2011 by Queen, the Top Tracks row shows that titl