HHS/simpler-grants-gov

The problem Currently a feature that is not working ideally is saved searches over 25. See the existing issue describing the problem Deleting_TopFewSavedSearch_DisplaysBottomFewSavedSearches.mp4 This is a pagination issue or rather a lack of, since the saved searches table component is based on the search results table which limits the results to 25, but we have not added the ability to support pagination. If you have access to the Simpler Grants slack, here is a slack thread on the issue and the fix. Steps to reproduce Sadly, to get this problem to be replicated, is a 25 step process 😓 Launch the URL. Log in. Enter a search term and/or apply search criteria. In the Current search query section, click Save. In the Name this search query modal, enter a name and click Save. Repeat steps 3-5 until more than 25 saved searches have been created. Navigate to Workspace -> Saved Search Queries. Observe the list of saved searches. Delete the top two save

Summary Environment simpler.grants.gov, opportunity detail/list views Affects mobile and desktop (governance/thresholds not currently aligned between them) Description When a user clicks "Show full description" on a truncated opportunity description, the additional text is revealed in a new row, but the ellipsis from the original truncation is not removed. The description also does not consistently truncate across opportunities: some show the "Show full description" control on text that shouldn't require truncation. Expected Result Ellipsis is removed once the full description is shown Truncation only triggers when description length exceeds a defined, consistent character threshold Same threshold logic applies predictably across mobile and desktop Descriptions under the threshold never show truncation or the "Show full description" control Actual Result Ellipsis remains visible after clicking "Show full description" Unnatural line break exists in description Truncation behavior i

Summary backend/grants_shared/src/grants_shared/util/file_util.py has three presigned-URL functions — pre_sign_file_location (line 122), pre_sign_upload (line 142), and presign_or_s3_cdnify_url (line 319) — but only two tests cover them in backend/grants_shared/tests/grants_shared/util/test_file_util.py: test_pre_sign_file_location_uses_configured_duration — asserts X-Amz-Expires == 900 test_presigned_post_local_override_with_s3_endpoint_url — asserts the localhost URL swap for pre_sign_upload Everything else about these functions is exercised only indirectly, via route tests like api/tests/src/api/files_v1/test_create_presigned_upload.py. The uncovered behavior is security-relevant: the POST policy conditions in pre_sign_upload are what stop a caller from overriding Content-Type, tampering with the x-amz-meta-* values the scanning lambda reads, uploading an oversized file, or replaying the URL to overwrite an existing object. If someone refactors the conditions list, no unit

Summary The ContentDisplayToggle currently Doesn’t include a prop for children so you can’t really see what it does Includes outdated props Acceptance criteria default variation for ContentDisplayToggle story includes children props documented for ContentDisplayToggle in story match props for component

Summary The current snackbar story shows the snackbar outside of the storybook viewport Acceptance criteria snackbar story shows the snackbar fully in viewport