Flagsmith/flagsmith

How are you running Flagsmith Self Hosted with Docker Self Hosted with Kubernetes SaaS at flagsmith.com Some other way (add details in description below) Describe the bug The public SDK OpenAPI spec (sdk/openapi.yaml) advertises trait_value as an unconstrained string, but the API still rejects string trait values longer than 2000 characters. The limit is enforced at runtime in api/environments/identities/traits/fields.py:27 via TRAIT_STRING_VALUE_MAX_LENGTH = 2000: Value string is too long. Must be less than 2000 character The spec previously documented it. trait_value.anyOf included {type: string, maxLength: 2000} — but the constraint was dropped in #6653 (flag-engine v10 upgrade, re-applied in #6741). The trait schema now derives from flag_engine.segments.types.ContextValue (None | int | float | bool | str), which carries no length constraint, so manage.py spectacular emits a plain string. Steps To Reproduce Open the sdk_v1_post_identities reference (or sdk/openapi.yaml) and

Acceptance criteria URL matching or view logic prevents an error with a proper 4xx response. Sentry Issue: FLAGSMITH-API-5NF ValueError: invalid literal for int() with base 10: 'org_3COWhASRXfhcdxVrd0wEjpQp4dg' File "django/db/models/fields/__init__.py", line 2128, in get_prep_value return int(value) ValueError: Field 'id' expected a number but got 'org_3COWhASRXfhcdxVrd0wEjpQp4dg'. (17 additional frame(s) were not displayed) ... File "features/views.py", line 861, in get_queryset return super().get_queryset().filter(identity__pk=self.kwargs["identity_pk"]) # type: ignore[no-untyped-call] Contributes to #6809

=================================== FAILURES =================================== _______________ test_cannot_create_superuser_if_any_user_exists ________________ [gw0] linux -- Python 3.11.14 /home/runner/.cache/pypoetry/virtualenvs/flagsmith-api-h9Rv37Cj-py3.11/bin/python admin_user = <FFAdminUser: [email protected]> api_client = <rest_framework.test.APIClient object at 0x7f6ac9dc2850> mocker = <pytest_mock.plugin.MockerFixture object at 0x7f6ac9dc3350> def test_cannot_create_superuser_if_any_user_exists( admin_user: FFAdminUser, api_client: APIClient, mocker: MockerFixture ) -> None: # Given mocker.patch("custom_auth.serializers.is_saas", return_value=False) email = "[email protected]" password = FFAdminUser.objects.make_random_password() register_data = { "email": email, "password": password, "re_password": password, "first_name": "user", "last_name": "test",

We're regularly seeing IntegrityError logs (example below) pop up, often because of poorly orchestrated scripts or racing frontend code. We should come up with a unified approach to these. The expectation is that the backend should handle the conflicts opaquely, or clearly indicate to the client why the request couldn't go through. Options are: a) Consider wrapping mutating operations in transactions — unlikely outcome as we don't want to increase lock contention. b) Return 409 Conflict — a bit tricky as it'd take some heuristics to accurately detect race-related IntegrityErrors. Sentry Issue: FLAGSMITH-API-5GY UniqueViolation: duplicate key value violates unique constraint "lowercase_feature_name" DETAIL: Key (lower(name::text), project_id)=(pltn.objectbuilder.fixemptypagerace, 13318) already exists. File "django/db/backends/utils.py", line 89, in _execute return self.cursor.execute(sql, params) IntegrityError: duplicate key value violates unique constraint "lowercase_fea

Sentry Issue: FLAGSMITH-API-5GZ KeyError: 'default_percentage_allocation' (9 additional frame(s) were not displayed) ... File "features/multivariate/views.py", line 89, in create return super().create(request, *args, **kwargs) File "features/multivariate/serializers.py", line 68, in validate total_sibling_percentage_allocation + attrs["default_percentage_allocation"]