DouglasNeuroInformatics/OpenDataCapture

The playground's "Interactive Instrument with Static Assets" example can never be completed. Its Submit handler calls done({ message }), but nothing in the instrument defines message, so clicking Submit throws ReferenceError: message is not defined and done is never called. Type-checking does not catch it, because a different example, Interactive-With-Legacy-Script/legacy.d.ts, declares declare let message: 'hello' as an ambient global. That declaration is in scope for every file under apps/playground/src, so tsc (and pnpm lint) accept the undefined identifier. Where apps/playground/src/instruments/examples/interactive/Interactive-With-Static-Assets/index.ts:18-23: render(done) { const button = document.getElementById('submit-btn')!; button.addEventListener('click', () => { done({ message }); }); }, The global that hides it, apps/playground/src/instruments/examples/interactive/Interactive-With-Legacy-Script/legacy.d.ts:1: declare let message: 'hello'; fragment.html has no ele

serve-instrument exits with an unhandled error when an instrument directory is deleted or renamed while it runs, or when it receives a URL with a malformed percent-escape. In both cases an exception escapes an async function that is called with void: this.handler.handle(...) for requests, and this.updateEncodedBundle() in the fs.watch callback. Node turns the unhandled rejection into a process exit. In updateEncodedBundle, only the bundle() call is inside the try; the readdir/readFile before it are not. In --all mode, deleting or renaming one instrument folder kills the server for all the others, and so does a git checkout that removes one. An author has to notice that the terminal died and restart it. Where packages/serve-instrument/src/server.tsx:45-48, 62-79 and 243-247, 312: this.watcher = fs.watch(target, { recursive: false }, () => { // ... void this.updateEncodedBundle(); }); // ... private async updateEncodedBundle(): Promise<void> { const inputs: Bund

Every failed instrument build reports one error too many. The extra error is the bundler crashing on itself: Cannot read properties of undefined (reading 'inputs'). The plugin's onEnd hook reads result.metafile!.inputs unconditionally, but esbuild does not produce a metafile when the build has errors. So the hook throws a TypeError, and esbuild appends it to BuildFailure.errors as a second error attributed to instrument-bundler-plugin. Any author with a syntax error or a missing file then sees "Build failed with 2 errors" and an internal TypeError alongside their real mistake. This appears in the playground's error fallback (its "Cause" section shows the esbuild message), in serve-instrument's log, and in the API's instrument repo import log. Where packages/instrument-bundler/src/plugin.ts:86-95: build.onEnd((result) => { result.legacyScripts = []; Object.keys(result.metafile!.inputs).forEach((path) => { const script = legacyScripts.get(path.replace('bun

The bundler rewrites any import of a subpath of a scoped runtime package to a URL that does not exist. For bare packages, the rule in plugin.ts appends /index.js to /runtime/v1/<pkg> and /runtime/v1/@scope/<pkg>. But its scope group is (@.*\/)?, and .* also matches /, so it swallows any number of path segments. /runtime/v1/@opendatacapture/runtime-core/constants therefore becomes /runtime/v1/@opendatacapture/runtime-core/constants/index.js instead of …/constants.js, and an import that already ends in .js gets /index.js appended after the .js. packages/instrument-bundler/AGENTS.md documents the opposite: only the bare package gets /index.js, and everything deeper gets .js. The import type-checks, because runtime/v1/dist/@opendatacapture/runtime-core/constants.d.ts exists. The bundle then fails to evaluate: on the API the subpath import does not resolve, and in the browser the module 404s. Today this affects FILE_TYPES from /runtime/v1/@opendatacapture/runtime-core/constants, and any f

An instrument file with an upper-case extension, such as a camera image IMG_0001.JPG or stim.PNG, breaks every tool that reads instrument files, with the error Pattern matching error: no pattern matches value ".PNG". BUNDLER_FILE_EXT_REGEX is case-insensitive (/i), so these files are accepted as inputs. But extractInputFileExtension returns the match with its original case, while declaring the lower-case BundlerInputFileExtension union as its return type. inferLoader then matches exhaustively on lower-case literals, and ts-pattern's .exhaustive() throws NonExhaustiveError for .PNG. What happens next depends on the consumer: bundle(): the build fails with that ts-pattern message instead of building or naming the unsupported file. the instrument-bundler CLI (the instrument-library build): crashes on the first such file in any instrument directory, even if nothing imports it. serve-instrument: the rejection escapes updateEncodedBundle and kills the dev server. InstrumentReposService.read