DioxusLabs/dioxus

Description In a Dioxus 0.7 web app, PNG assets included via asset!() appear to be re-encoded by default during dx bundle. This can significantly increase the size of already optimized production images. For example, in my project: public/assets/forest-background.png 193K dist/public/assets/forest-background.png 976K dist/public/assets/forest-background-dxh...png 976K The same problem happens with other optimized PNG files: public/assets/forest-background-winter.png 224K dist/public/assets/forest-background-winter.png 806K public/assets/satchel-background-winter.png 212K dist/public/assets/satchel-background-winter.png 1.1M The main issue is that asset!() appears to optimize/re-encode images by default, but for already optimized PNGs this makes the files much larger. Expected behavior By default, asset!() should not change image bytes. I would expect asset!() to: 1. copy/bundle the asset 2. optionally hash the filename 3. preserve the original file bytes unl

Problem on running dx build --verbose --trace --server --fullstack true --features fullstack --release --ssg I get this warning from my browser This page is in Quirks Mode. Page layout may be impacted. For Standards Mode use “<!DOCTYPE html>” Steps To Reproduce Steps to reproduce the behavior: create a new dioxus workspace project (crates: app, pages) put your router inside pages crate and make it public add this to app/src/main.rs use dioxus::prelude::*; #[cfg(not(target_arch = "wasm32"))] #[cfg(feature = "server")] #[tokio::main] async fn main() { rustls::crypto::ring::default_provider() .install_default() .expect("Failed to install ring crypto provider"); let certs_dir = std::env::var("CERTS_DIR").expect("CERTS_DIR must be set"); let rustls_config = axum_server::tls_rustls::RustlsConfig::from_pem_file( format!("{}/server.crt", certs_dir), format!("{}/server.key", certs_dir), ) .await .expect("Failed to load TLS config"

Feature Request You can currently not set the image size for images or set both the width and height. You should be able to set either the width or height and have the other derived from the aspect ratio of the image Implement Suggestion Allow with_width or with_height and derive the other dimension // Resize the image at compile time to make the assets smaller pub const RESIZED_PNG_ASSET: Asset = asset!("/assets/image.png", AssetOptions::image().with_width(52)); or // Resize the image at compile time to make the assets smaller pub const RESIZED_PNG_ASSET: Asset = asset!("/assets/image.png", AssetOptions::image().with_height(52));

I just realized that the default Rust edition in Cargo.toml file is still 2021 for dx creating a new project. It's 2026 now, lots of Rust crates are moving to edition 2024 so that we can benefit all the improvement directly. It's just a proposal, and I would like to hear your feedback on decision. Thanks a lot!

Feature Request I want to be able to set the state type on the router that's created when using the dioxus::server::router function. Implement Suggestion The function is located in https://github.com/DioxusLabs/dioxus/blob/main/packages/fullstack-server/src/launch.rs line 96. change it from: pub fn router(app: fn() -> Element) -> Router { //.... } to: pub fn router<State = ()>(app: fn() -> Element) -> Router<State> { // Setting the default to `()` should ensure compatability with existing apps //.... } That way I can do this: dioxus::server::router::<crate::server::state::ArcStore>(App).with_state(store) // a struct wrapped in an Arc You'll probably have to update some of the other functions that expect just a Router like serve.