AprilSylph/XKit-Rewritten

Platform n/a Browser n/a Addon version n/a Details I haven't managed to reproduce this in a supported browser, but it occurred while doing some off-label testing and I do think logically it should be possible to occur in any browser. Classic Footer can create duplicate post counts and reblog buttons the first time it is enabled in an installation. This is because its processPosts function doesn't have robust deduplication (it does not use filterPostElements with an excludeClass argument, and its removal code is separated from its addition code by two awaits, which means a possible race condition), and because it triggers this function in onStorageChanged. onStorageChanged will be called when its preferences are updated, which occurs the first time it is enabled in an installation, because we populate default preferences at that point.

Platform macOS 14.8.8 arm64 Browser Firefox 155.0.1 Addon version master (v1.3.7) Details If Classic Search is enabled and then disabled without ever seeing a search element, such as on a narrow viewport, searchInputParent is never defined as anything and this will throw: XKit-Rewritten/src/features/classic_search/index.js Lines 42 to 48 in a12e16e export const clean = async function () { pageModifications.unregister(replaceSearchForm); searchInputParent.appendChild(searchInputElement); removeElementsByClassName('classic-search'); $('.xkit-classic-search-done').removeClass('xkit-classic-search-done'); };

Platform MacOS Browser Firefox 155.0.1 Addon version master branch Details Typing something into the search box with Classic Search enabled and pressing enter navigates to a broken page.

Description Animated avatars, at time of writing, don't exist, but they narrowly won a recent poll on the tumblr engineering blog, so we could attempt to ship support in advance in case they do get implemented. Technically, the only code that actually has to be changed is this line, which per #1746 (and #1804) was in order to not put gif labels on non-animated gif avatars. (We do have the ability to check if gifs are animated, now, if we really want to be correct about this edge case.) XKit-Rewritten/src/features/accesskit/disable_gifs.js Line 192 in 2d561ce if (gifElement.closest(`${keyToCss('avatarImage', 'subAvatarImage')}, .block-editor-writing-flow`)) return; But this doesn't actually look great, imo; we probably want to make a UI that's better-looking than this: (I wouldn't mind so much if the only way to get an animated avatar was via workarounds, like it was that o

Description https://www.tumblr.com/engineering/825845466763837440/now-in-labs-full-screen-messaging-on-web Full-screen messaging: it's great; I probably would want to use it, at minimum, the vast majority of the time. Completely replacing current messaging with it would probably be a bit of a niche toggle for Tumblr to add (though I did comment suggesting this); I can't deny that there's legitimate utility in being able to use the traditional bubble system sometimes, so making the messaging sidebar item go straight to /messages is kind of a power user thing. That's what XKit tweaks are for, though, right? Note that full screen messages is a labs feature, but that I can tell, the labs toggle just adds the button to actually go to /messages; the route works fine either way. So if this were a tweak, it wouldn't actually have to check if the labs feature is enabled. (If the feature were removed from the site, it would be bad, though, and being a labs feature is presumably intended as a sig