AcademySoftwareFoundation/MaterialX

Issue Text in property panel, main menu and title area for graph panel are twice too large. Workaround Use the the uiscale command option to scale by 1/2 (0.5). Implementation Notes On Mac, ImGui already tries to compensate for Retina, high DPI displays. Thus this should not be done when initializing the app (as for Windows and X). This is one possible way to approach fixing in Main.cpp. Needs to be vetted. // Derive a single effective UI scale from device DPI and optional CLI multiplier. + float deviceScale = 1.0f; +#if !defined(__APPLE__) + // On macOS (Retina) the framebuffer tracks the content scale, and ImGui already + // converts logical units to pixels using io.DisplayFramebufferScale, so scaling + // the UI by the content scale as well doubles the scale. On Windows and X11 + // the framebuffer is unscaled, so the content scale is the only way to get the DPI. float xscale = 1.0f, yscale = 1.0f; glfwGetWindowContentScale(window, &xscale, &yscale); -

Description Split out from "MaterialX Graph Editor Needs Unit Tests #3013 First task : "Data integrity : Load / save of documents (tests conversion to/from MTLX to UI graph data model)" Proposed Changes This entails: Adding a -s/--save <materialxDocument.mtlx> command option. Add a test to compare after a load / save (*) (*) One thing that will hinder any comparison test is the default of saving UI position (xpos and ypos) so maybe also add in those options on the command line if time permits.

Another edge case on the upgrade path. If you add this test case to MaterialXTest/MaterialXCore/Document.cpp and run with MATERIALX_DYNAMIC_ANALYSIS=ON. TEST_CASE("Document upgrade swizzle empty value", "[document]") { mx::DocumentPtr doc = mx::createDocument(); mx::XmlReadOptions readOptions; readOptions.upgradeVersion = false; mx::readFromXmlString(doc, "<?xml version=\"1.0\"?>" "<materialx version=\"1.38\">" " <nodegraph name=\"NG1\">" " <swizzle name=\"swz1\" type=\"color3\" nodedef=\"ND_swizzle\">" " <input name=\"in\" type=\"color3\" value=\"\"/>" " <input name=\"channels\" type=\"string\" value=\"\"/>" " </swizzle>" " </nodegraph>" "</materialx>", mx::FileSearchPath(), &readOptions); REQUIRE_NOTHROW(doc->upgradeVersion()); } /usr/include/c++/11/bits/stl_vector.h:1046:34: runtime error: reference binding to null pointer of type 'struct value_type' It's specifical

A tidied up fuzz finding. This one's on a highly infeasible path. You'll only see it triggered if you have MATERIALX_DYNAMIC_ANALYSIS=ON. If you add this test case to MaterialXTest/MaterialXCore/Document.cpp TEST_CASE("Document upgrade switch null value", "[document]") { mx::DocumentPtr doc = mx::createDocument(); mx::XmlReadOptions readOptions; readOptions.upgradeVersion = false; mx::readFromXmlString( doc, R"(<?xml version="1.0"?> <materialx version="1.38"> <nodegraph name="NG1"> <switch name="sw1" type="integer" nodedef="ND_switch"> <input name="which" type="integer" value="abc"/> </switch> </nodegraph> </materialx> )", mx::FileSearchPath(), &readOptions ); REQUIRE_NOTHROW(doc->upgradeVersion()); } /home/sean/MaterialX/source/MaterialXCore/Version.cpp:1171:45: runtime error: member call on null pointer of type 'struct

The specification states that uniform inputs can only be connected to the output of a <constant> node (possibly through one or more no-op <dot> nodes) or to any other node whose output is explicitly declared to be "uniform". However, connections to non-uniform outputs are allowed in the graph editor and seem to be perfectly valid (see the frameoffset uniform input of tiledimage in the screenshot below): Am I missing something? Thanks, Joël